Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(brand): allowed heights/widths to be set together and be used when no children are passed #9342

Merged
merged 2 commits into from
Jul 11, 2023
Merged

fix(brand): allowed heights/widths to be set together and be used when no children are passed #9342

merged 2 commits into from
Jul 11, 2023

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented Jul 10, 2023

fixes #9341

@mcoker mcoker requested a review from tlabaj July 10, 2023 21:14
@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 10, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-9342.surge.sh

A11y report: https://patternfly-react-pr-9342-a11y.surge.sh

@mcoker mcoker requested a review from kmcfaul July 10, 2023 21:24
@mcoker mcoker mentioned this pull request Jul 10, 2023
Merged
tlabaj
tlabaj approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tlabaj tlabaj merged commit eca7300 into patternfly:main Jul 11, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.0.0-prerelease.20
  • @patternfly/react-core@5.0.0-prerelease.20
  • @patternfly/react-docs@6.0.0-prerelease.22
  • demo-app-ts@5.0.0-prerelease.18
  • @patternfly/react-table@5.0.0-prerelease.20

Thanks for your contribution! 🎉

@nicolethoen nicolethoen mentioned this pull request Jul 12, 2023
Merged
nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
@mcoker @nicolethoen
fix(brand): allowed heights/widths to be set together and be used whe…
1191c52 
…n no children are passed (patternfly#9342)

* fix(brand): allowed heights/widths to be set together and be used when no children are passed

* chore(brand): docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmcfaul kmcfaul kmcfaul approved these changes

@tlabaj tlabaj tlabaj approved these changes

@gitdallas gitdallas gitdallas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - Brand - setting heights and widths together results in only heights being set
5 participants
@mcoker @patternfly-build @gitdallas @tlabaj @kmcfaul